Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus process metrics exporter #907

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jun 6, 2024

This PR also reorganizes a bit the code, moving the prometheus expirer and prometheus network metrics to the internal/export/prom package.

@mariomac mariomac marked this pull request as ready for review June 6, 2024 09:40
@mariomac mariomac requested review from grcevski and marctc as code owners June 6, 2024 09:40
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.11%. Comparing base (65007e1) to head (9c921f1).

Files Patch % Lines
pkg/internal/export/prom/prom_proc.go 91.48% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #907       +/-   ##
===========================================
- Coverage   78.05%   67.11%   -10.94%     
===========================================
  Files         132      130        -2     
  Lines        9620     9665       +45     
===========================================
- Hits         7509     6487     -1022     
- Misses       1608     2609     +1001     
- Partials      503      569       +66     
Flag Coverage Δ
integration-test 55.39% <90.19%> (+0.50%) ⬆️
k8s-integration-test 59.38% <93.13%> (+2.98%) ⬆️
oats-test ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 163faa3 into grafana:main Jun 7, 2024
6 checks passed
@mariomac mariomac deleted the proc-prom branch June 7, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants