Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check kafka pkt length before parsing clientid #906

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

esara
Copy link
Contributor

@esara esara commented Jun 6, 2024

check kafka pkt length before parsing clientid

address #905

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (294a8d9) to head (ef576d0).

Files Patch % Lines
pkg/internal/ebpf/common/kafka_detect_transform.go 73.46% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
+ Coverage   77.87%   77.99%   +0.11%     
==========================================
  Files         126      126              
  Lines        9136     9153      +17     
==========================================
+ Hits         7115     7139      +24     
+ Misses       1551     1542       -9     
- Partials      470      472       +2     
Flag Coverage Δ
integration-test 53.93% <26.53%> (+0.19%) ⬆️
k8s-integration-test 58.77% <0.00%> (+0.04%) ⬆️
oats-test 37.03% <73.46%> (+0.05%) ⬆️
unittests 43.72% <69.38%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esara esara force-pushed the kafkaheaderlength branch from f2639b8 to ef576d0 Compare June 6, 2024 05:02
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski
Copy link
Contributor

grcevski commented Jun 6, 2024

Thanks @esara for your contribution!

@mariomac mariomac added the bug label Jun 6, 2024
@mariomac mariomac merged commit 8676f4e into grafana:main Jun 6, 2024
7 checks passed
@esara esara deleted the kafkaheaderlength branch September 29, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants