Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Go Kafka events using the current parser #900

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Jun 3, 2024

This PR finishes the work to generate Go Kafka events from Go Sarama library calls. It now uses the code that @marctc made for creating Kafka events from TCP.

Added OATS test, noticed the span kinds were reported as internal instead of consumer/producer and fixed that.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (294a8d9) to head (e4926a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   77.87%   78.47%   +0.59%     
==========================================
  Files         126      126              
  Lines        9136     9164      +28     
==========================================
+ Hits         7115     7191      +76     
+ Misses       1551     1501      -50     
- Partials      470      472       +2     
Flag Coverage Δ
integration-test 53.73% <0.00%> (-0.02%) ⬇️
k8s-integration-test 58.67% <0.00%> (-0.05%) ⬇️
oats-test 37.69% <100.00%> (+0.71%) ⬆️
unittests 43.51% <21.95%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit ac5333d into grafana:main Jun 6, 2024
6 checks passed
@grcevski grcevski deleted the finish_kafka_go branch June 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants