-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kafka support #890
Add kafka support #890
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 72.28% 78.01% +5.73%
==========================================
Files 124 125 +1
Lines 8857 9124 +267
==========================================
+ Hits 6402 7118 +716
+ Misses 2033 1542 -491
- Partials 422 464 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I fixed up bunch of things:
One thing that doesn't work is the metric attributes. I can't see why we aren't adding MessagingSystem and MessagingDestinationName. Something that needs to be debugged. The metrics are split by "publish" and "processing". Processing is the receive part, but according to the spec it's more broad and should include the push of messages too. Here's an example of my metrics:
there should be messaging_system and messaging_destination_name attribute there. |
|
||
class RequestHandler(BaseHTTPRequestHandler): | ||
def do_GET(self): | ||
if self.path == '/message': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this doing anything? Do we still need a web server in this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it does nothing at the moment, I wasn't sure we can make a test without it. I don't mind it being there.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome stuff Marc!
Add support to track process (consume/fetch) and publish client operations for Kafka in non-Go services.
The PR includes an integration test with a Python example.