Fix http parsing for duplicate HTTP #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
May 28, 2024
| //HTTP | ||
| if ((p[0] == 'H') && (p[1] == 'T') && (p[2] == 'T') && (p[3] == 'P')) { | ||
| //HTTP/1.x | ||
| if ((p[0] == 'H') && (p[1] == 'T') && (p[2] == 'T') && (p[3] == 'P') && (p[4] == '/') && (p[5] == '1') && (p[6] == '.')) { |
There was a problem hiding this comment.
Be more specific on what you are looking for, HTTP is not enough.
grcevski
commented
May 28, 2024
| @@ -337,6 +338,9 @@ static __always_inline void process_http_response(http_info_t *info, unsigned ch | |||
| info->status += (buf[RESPONSE_STATUS_POS] - '0') * 100; | |||
| info->status += (buf[RESPONSE_STATUS_POS + 1] - '0') * 10; | |||
| info->status += (buf[RESPONSE_STATUS_POS + 2] - '0'); | |||
| if (info->status > MAX_HTTP_STATUS) { // we read something invalid | |||
There was a problem hiding this comment.
Defensive measure to at reset the status if we parsed something incorrect, allowing us to potentially find the correct response (or at least set 0).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 77.57% 77.12% -0.46%
==========================================
Files 122 122
Lines 8594 8594
==========================================
- Hits 6667 6628 -39
- Misses 1482 1522 +40
+ Partials 445 444 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
approved these changes
May 29, 2024
marctc
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our kprobes HTTP parsing had some edge case bugs:
GETand similar. Now we check if we'd already seen a request start for the given connection.I believe this bug was accidentally introduced with our previous released addition for correct tracking of response times for large requests. Namely, previously we'd send the captured event as soon as we saw the HTTP/1.1 in the response. Now, we keep things alive until the client and server stop communicating, which exposed us to potentially re-parsing the HTTP end if we saw another
HTTP.Closes #885