Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial infrastructure for dealing with Kafka protocol in Go #886

Merged
merged 10 commits into from
May 29, 2024

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented May 28, 2024

This PR doesn't add any visible functionality, it adds support for Kafka tracking in Go, but we ignore the events. I'm adding the PR so that @marctc can build the remaining protocol parsing, which is common for non-Go.

I added components for integration testing in Go, but I can't write any tests yet since we don't parse the protol info.

Relates to #872

@grcevski grcevski requested review from mariomac and marctc as code owners May 28, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 38.14433% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 77.60%. Comparing base (48b713e) to head (abc80f0).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/internal/ebpf/gokafka/gokafka.go 40.22% 52 Missing ⚠️
pkg/internal/ebpf/common/go_kafka_transform.go 0.00% 6 Missing ⚠️
pkg/internal/ebpf/common/common.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   78.10%   77.60%   -0.51%     
==========================================
  Files         120      122       +2     
  Lines        8497     8594      +97     
==========================================
+ Hits         6637     6669      +32     
- Misses       1414     1481      +67     
+ Partials      446      444       -2     
Flag Coverage Δ
integration-test 55.66% <38.14%> (-0.26%) ⬇️
k8s-integration-test 61.62% <38.14%> (-0.36%) ⬇️
oats-test 34.20% <38.14%> (+0.04%) ⬆️
unittests 43.46% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@marctc marctc merged commit ccc8f20 into grafana:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants