-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial infrastructure for dealing with Kafka protocol in Go #886
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 78.10% 77.60% -0.51%
==========================================
Files 120 122 +2
Lines 8497 8594 +97
==========================================
+ Hits 6637 6669 +32
- Misses 1414 1481 +67
+ Partials 446 444 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
This PR doesn't add any visible functionality, it adds support for Kafka tracking in Go, but we ignore the events. I'm adding the PR so that @marctc can build the remaining protocol parsing, which is common for non-Go.
I added components for integration testing in Go, but I can't write any tests yet since we don't parse the protol info.
Relates to #872