Restore service.name as metric attribute #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 79.86% 79.76% -0.10%
==========================================
Files 117 117
Lines 8054 8060 +6
==========================================
- Hits 6432 6429 -3
- Misses 1217 1226 +9
Partials 405 405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Beyla 1.5 and lower, the OTEL exporter reported service.name both as metric and resource attribute.
This seemed like a mistake so Beyla 1.6 removed the metric attribute, and service_name was still visible in integration tests, taken from the resource attribute.
However, the
service_namehas dissappeared from our dashboard in Grafana Cloud, as Mimir seems to be configured to ignore that value when it is reported as resource attribute. This broke our dashboards and needs to be restored in Beyla 1.6.2.