Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options for traces backoff config #865

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented May 23, 2024

Add configuration options in TracesConfig to configure some of the parameters
of the retry config (or backoff config) of traces exporter.

@marctc marctc requested review from grcevski and mariomac as code owners May 23, 2024 12:40
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 79.69%. Comparing base (b61e5c7) to head (7df6a2b).

Files Patch % Lines
pkg/internal/export/otel/traces.go 36.36% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   79.86%   79.69%   -0.18%     
==========================================
  Files         117      117              
  Lines        8054     8065      +11     
==========================================
- Hits         6432     6427       -5     
- Misses       1217     1230      +13     
- Partials      405      408       +3     
Flag Coverage Δ
integration-test 56.78% <36.36%> (+0.42%) ⬆️
k8s-integration-test 65.01% <36.36%> (-0.14%) ⬇️
oats-test 35.89% <36.36%> (+<0.01%) ⬆️
unittests 46.19% <36.36%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you think is worth documenting the new options? (we tend to keep some very internal options as undocumented)

@marctc
Copy link
Contributor Author

marctc commented May 24, 2024

Do you think is worth documenting the new options? (we tend to keep some very internal options as undocumented)

I considered these options same as the other ones (such as ExportTimeout) so I guess once we document those, we could also document these ones. Wdyt?

@renaudrenaud
Copy link

Do you think is worth documenting the new options? (we tend to keep some very internal options as undocumented)

Grafana and other products for the company are now a joke relative how the documentation is managed. The result of the documentation quality is the fact that installing and working with the product is a challenge. Of course the results are beautiful, but man, sometimes it is too hard and too much time to spend on it. Just spend few minutes on the Grafana Community and you will understand. For me you are stuck in the developper mindset and don't understand the difficulties from a user point of view.

@mariomac
Copy link
Contributor

So @renaudrenaud would you consider that a "debugging parameters" section in our documentation would be helpful for you?

@renaudrenaud
Copy link

Mario, thanks a lot for what you have done, but let me explain this.
I've installed version 1.5.3 and the traces produced are all about html.
2024-05-20 04:30:51.52043051 (39.584061ms[39.584061ms]) SRV 302 POST /arc/arc_check [::1 as localhost]->[::1 as java:11080] size:1490B svc=[java java] traceparent=[]
2024-05-20 04:30:52.52043052 (49.802118ms[49.802118ms]) SRV 200 GET /arc/secure/arc.htm [::1 as java]->[::1 as java:11080] size:1121B svc=[java java] traceparent=[00-873fe64e8846010751b733185fb97aa0-0000000000000000-01]
...
Then 2 weeks later on the same vm with the same configuration but v1.6.1 the traces are all about SQL.
2024-05-27 10:51:27.527105127 (7.268µs[7.268µs]) SQL 0 SELECT [127.0.0.1 as java]->[127.0.0.1 as java:5432] size:0B svc=[java java] traceparent=[]
2024-05-27 10:51:27.527105127 (23.158µs[23.158µs]) SQL 0 SELECT [127.0.0.1 as java]->[127.0.0.1 as java:5432] size:0B svc=[java java] traceparent=[]
2024-05-27 10:51:27.527105127 (2.56401ms[2.56401ms]) SQL 0 SELECT [127.0.0.1 as java]->[127.0.0.1 as java:5432] size:0B svc=[java java] traceparent=[]
I would like to understand why. Is there any swith / parameter I did not found in the documentation?

@marctc
Copy link
Contributor Author

marctc commented May 27, 2024

@renaudrenaud thanks for your feedback and suggestions, highly appreciated but:

  • Keep a respectful tone, please
  • Open a separate discussion/issue instead derailing the conversation in a different issue/PR

thanks

@mariomac
Copy link
Contributor

@renaudrenaud that sounds like a bug. Would you mind filing an issue and provide some details about your setup and instrumented applications? https://github.com/grafana/beyla/issues

@marctc marctc merged commit cc7ef5d into main May 27, 2024
6 checks passed
@marctc marctc deleted the add_backoff_config branch May 27, 2024 09:20
@renaudrenaud
Copy link

@renaudrenaud thanks for your feedback and suggestions, highly appreciated but:

  • Keep a respectful tone, please
  • Open a separate discussion/issue instead derailing the conversation in a different issue/PR

thanks
Your products are great but their doc generate a lot of frustration. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants