-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config options for traces backoff config #865
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 79.86% 79.69% -0.18%
==========================================
Files 117 117
Lines 8054 8065 +11
==========================================
- Hits 6432 6427 -5
- Misses 1217 1230 +13
- Partials 405 408 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do you think is worth documenting the new options? (we tend to keep some very internal options as undocumented)
I considered these options same as the other ones (such as |
Grafana and other products for the company are now a joke relative how the documentation is managed. The result of the documentation quality is the fact that installing and working with the product is a challenge. Of course the results are beautiful, but man, sometimes it is too hard and too much time to spend on it. Just spend few minutes on the Grafana Community and you will understand. For me you are stuck in the developper mindset and don't understand the difficulties from a user point of view. |
So @renaudrenaud would you consider that a "debugging parameters" section in our documentation would be helpful for you? |
Mario, thanks a lot for what you have done, but let me explain this. |
@renaudrenaud thanks for your feedback and suggestions, highly appreciated but:
thanks |
@renaudrenaud that sounds like a bug. Would you mind filing an issue and provide some details about your setup and instrumented applications? https://github.com/grafana/beyla/issues |
|
Add configuration options in
TracesConfig
to configure some of the parametersof the retry config (or backoff config) of traces exporter.