Update default Beyla version in helm chart #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
commented
May 23, 2024
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| name: beyla | |||
| version: 1.1.1 | |||
| appVersion: 1.5.2 | |||
| version: 1.2.0 | |||
There was a problem hiding this comment.
I don't have a clear opinion here. Do updating a minor version of the appVersion deserve an update of the minor version of the chart?
There was a problem hiding this comment.
In https://github.com/grafana/helm-charts the script would just bump to 1.1.2, but I guess i doesn't matter much
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 117 117
Lines 8054 8054
=======================================
Hits 6423 6423
Misses 1226 1226
Partials 405 405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
approved these changes
May 23, 2024
Closed
mariomac
commented
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.