Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes filter network documentation #861

Merged
merged 3 commits into from
May 23, 2024

Conversation

mariomac
Copy link
Contributor

The unstable allowed_attributes option was replaced but it was still visible on some documents.

After merging this PR, it must be backported to release-1.6.

@mariomac mariomac requested review from grcevski and marctc as code owners May 23, 2024 07:29
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.89%. Comparing base (c7c8ba5) to head (bdebe06).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #861       +/-   ##
===========================================
- Coverage   79.74%   35.89%   -43.86%     
===========================================
  Files         117      114        -3     
  Lines        8054     8026       -28     
===========================================
- Hits         6423     2881     -3542     
- Misses       1226     4782     +3556     
+ Partials      405      363       -42     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test 35.89% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac requested a review from grafsean May 23, 2024 07:38
@mariomac mariomac merged commit 9d5da6c into grafana:main May 23, 2024
8 checks passed
@mariomac mariomac deleted the fix-net-docs branch May 23, 2024 08:50
mariomac added a commit to mariomac/beyla that referenced this pull request May 23, 2024
Backport of (grafana#861)

* Fix documentation

* Fix unit test

* Edit

---------

Co-authored-by: Sean Packham <[email protected]>
mariomac added a commit that referenced this pull request May 23, 2024
Backport of (#861)

* Fix documentation

* Fix unit test

* Edit

---------

Co-authored-by: Sean Packham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants