Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array index panic on SQL parsing #855

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented May 22, 2024

Fixes #854

@mariomac mariomac requested review from grcevski and marctc as code owners May 22, 2024 14:53
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (bd41788) to head (9796601).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #855       +/-   ##
===========================================
- Coverage   76.04%   56.36%   -19.69%     
===========================================
  Files         117      114        -3     
  Lines        8050     8030       -20     
===========================================
- Hits         6122     4526     -1596     
- Misses       1503     3097     +1594     
+ Partials      425      407       -18     
Flag Coverage Δ
integration-test 56.36% <100.00%> (?)
k8s-integration-test ?
oats-test ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 736ea23 into grafana:main May 22, 2024
6 checks passed
@mariomac mariomac deleted the fix-array branch May 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla 1.6 crashes with 'slice bounds out of range'
3 participants