Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track connection errors in grpc_go #852

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented May 21, 2024

Add code to ensure we can track failed gRPC connections in Go.

TODO:

  • Integration tests

@grcevski grcevski requested review from mariomac and marctc as code owners May 21, 2024 21:43
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (a22db74) to head (fb63622).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   79.63%   79.74%   +0.10%     
==========================================
  Files         117      117              
  Lines        8050     8054       +4     
==========================================
+ Hits         6411     6423      +12     
+ Misses       1231     1226       -5     
+ Partials      408      405       -3     
Flag Coverage Δ
integration-test 56.42% <100.00%> (+0.17%) ⬆️
k8s-integration-test 65.11% <100.00%> (-0.07%) ⬇️
oats-test 35.89% <100.00%> (+0.34%) ⬆️
unittests 46.25% <0.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit c7c8ba5 into grafana:main May 22, 2024
6 checks passed
@grcevski grcevski deleted the connect_fail branch May 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants