Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize bpf2go in makefile with version in go.mod #610

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 8, 2024

bpf2go remains outdated with respect to the cilium/ebpf version that we still have in the go.mod file.

This script synchronizes the version passed to go install wit the version in the go.mod file.

@mariomac mariomac requested a review from grcevski as a code owner February 8, 2024 15:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19b91e8) 79.83% compared to head (ef80633) 79.59%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   79.83%   79.59%   -0.24%     
==========================================
  Files          70       70              
  Lines        5946     5946              
==========================================
- Hits         4747     4733      -14     
- Misses        976      986      +10     
- Partials      223      227       +4     
Flag Coverage Δ
integration-test 69.15% <ø> (-0.25%) ⬇️
unittests 45.01% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac requested a review from marctc February 8, 2024 16:24
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@mariomac mariomac merged commit fed2351 into grafana:main Feb 9, 2024
4 checks passed
@mariomac mariomac deleted the gomod-ver branch February 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants