-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed gRPC 1.61 offsets and updated go.mod versions #609
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
===========================================
- Coverage 79.88% 69.27% -10.61%
===========================================
Files 70 67 -3
Lines 5947 5830 -117
===========================================
- Hits 4751 4039 -712
- Misses 974 1510 +536
- Partials 222 281 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've seen this before, depending on the distro we build on sometimes there are these verifier errors. I can't see them anymore after I've recompiled. I'm investigating more. |
OK, so as I expected, compiling on Ubuntu worked, but I reproduced the issue by compiling on Fedora. I believe I fixed the issue by using this new helper I added some time ago |
Thanks @nikola! I will change the base image of the docker generator, then. |
A couple of the dependencies had vulnerabilities.
Also I wanted to get the latest version of the OTEL SDK, for improved Prometheus support.
I also found and fix a bug in the way we handled the gRPC removed address fields (see comment below)