Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganizing Beyla configuration packages #584

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

mariomac
Copy link
Contributor

During the preparation for Asserts work and integration of multiple configuration sources, the import cycles became unmanageable.

To prepare future, deeper refactors, this PR does:

  • renames package beyla to appobserv.
  • creates a new beyla package and moves there all the configuration options. Now we have just a single beyla.Config structure, instead of the pipe.Config and its public facet beyla.Config.

@mariomac mariomac requested a review from grcevski as a code owner January 29, 2024 16:11
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (78e18f4) 79.63% compared to head (2978213) 44.95%.

Files Patch % Lines
pkg/internal/discover/finder.go 0.00% 5 Missing ⚠️
pkg/internal/discover/attacher.go 0.00% 1 Missing ⚠️
pkg/internal/discover/watcher_proc.go 0.00% 1 Missing ⚠️
pkg/internal/ebpf/httpfltr/httpfltr.go 0.00% 1 Missing ⚠️
pkg/internal/ebpf/httpssl/httpssl.go 0.00% 1 Missing ⚠️
pkg/internal/ebpf/watcher/watcher.go 0.00% 1 Missing ⚠️
pkg/internal/pipe/instrumenter.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #584       +/-   ##
===========================================
- Coverage   79.63%   44.95%   -34.68%     
===========================================
  Files          70       68        -2     
  Lines        5917     5739      -178     
===========================================
- Hits         4712     2580     -2132     
- Misses        980     3005     +2025     
+ Partials      225      154       -71     
Flag Coverage Δ
integration-test ?
unittests 44.95% <21.42%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a great approach!

@mariomac mariomac merged commit ec757bd into grafana:main Jan 30, 2024
4 checks passed
@mariomac mariomac deleted the beyla-pkg-reorg branch January 30, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants