Fix wrong reported program type and missing traces #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
Jan 16, 2024
| @@ -130,7 +131,7 @@ static __always_inline u8 correlated_requests(tp_info_pid_t *tp, tp_info_pid_t * | |||
| // We check for correlated requests which are in order, but from different PIDs | |||
| // Same PID means that we had client port reuse, which might falsely match prior | |||
| // transaction if it happened during the same epoch. | |||
| if ((tp->tp.ts > existing_tp->tp.ts) && (tp->pid != existing_tp->pid)) { | |||
| if ((tp->tp.ts >= existing_tp->tp.ts) && (tp->pid != existing_tp->pid)) { | |||
There was a problem hiding this comment.
These could be the same if the requests are too quick to happen one after another.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
===========================================
- Coverage 79.32% 45.04% -34.28%
===========================================
Files 69 67 -2
Lines 5828 5652 -176
===========================================
- Hits 4623 2546 -2077
- Misses 984 2955 +1971
+ Partials 221 151 -70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were re-using the process tracers we weren't setting the program type on the service id. It would only be seen by duplicated executables, which we have plenty of in multi-exec. I also found that we weren't pinning certain maps which held the information on currently processed traces, so depending on which kernel program ran we might miss some trace events. I also fixed some prints which were on when debug was disabled.
Closes #532