Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile #551

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix Dockerfile #551

merged 3 commits into from
Jan 16, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jan 16, 2024

Replaced CMD by ENTRYPOINT in Beyla. This should be the standard way of specifying a container command.

This will cause that some docker-compose setups will break because this command value won't be valid anymore:

command:
- /beyla
- config-file.yml

The correct and standard way will be:

command:
- config-file.yml

Kubernetes deployments will still keep working because they accept either command for the whole CLI and args for the arguments.

I will document this as the very first item in the release notes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6dc92c) 79.19% compared to head (b81383d) 45.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #551       +/-   ##
===========================================
- Coverage   79.19%   45.18%   -34.01%     
===========================================
  Files          69       67        -2     
  Lines        5815     5637      -178     
===========================================
- Hits         4605     2547     -2058     
- Misses        987     2939     +1952     
+ Partials      223      151       -72     
Flag Coverage Δ
integration-test ?
unittests 45.18% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@mariomac mariomac merged commit 2dc3859 into main Jan 16, 2024
4 checks passed
@mariomac mariomac deleted the fix-dockerfile branch January 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants