Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BEYLA_CONFIG_PATH env var #549

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add BEYLA_CONFIG_PATH env var #549

merged 2 commits into from
Jan 16, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jan 15, 2024

Adding @grafsean as a reviewer, as this PR affects documentation.

As an addition to the -config CLI argument, the introduced BEYLA_CONFIG_PATH env var would allow cleaner configuration in container-based environments, not forcing the users to override the /beyla command invocation (which should be kept as an internal detail).

The good-old -config CLI arg will keep working as usual.

@mariomac mariomac requested a review from grafsean January 15, 2024 15:07
@mariomac mariomac requested a review from grcevski as a code owner January 15, 2024 15:07
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only have one suggestion/question, should we name this variable as BEYLA_CONFIG_PATH or BEYLA_CONFIG_FILE? I'm concerned that folks may think this is an environment variable containing the contents of the config, rather than path to the config file.

@mariomac
Copy link
Contributor Author

@grcevski very good point. I'll change it to BEYLA_CONFIG_PATH

@mariomac mariomac changed the title Add BEYLA_CONFIG env var Add BEYLA_CONFIG_PATH env var Jan 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99088fd) 67.64% compared to head (2a3f712) 44.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #549       +/-   ##
===========================================
- Coverage   67.64%   44.91%   -22.73%     
===========================================
  Files          66       67        +1     
  Lines        5687     5628       -59     
===========================================
- Hits         3847     2528     -1319     
- Misses       1553     2946     +1393     
+ Partials      287      154      -133     
Flag Coverage Δ
integration-test ?
unittests 44.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafsean
Copy link
Contributor

Looks good, little copy touched!

@mariomac mariomac merged commit b6dc92c into grafana:main Jan 16, 2024
5 checks passed
@mariomac mariomac deleted the beyla-config branch January 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants