-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to group tutorials into a folder #545
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 79.48% 79.32% -0.16%
==========================================
Files 69 69
Lines 5781 5781
==========================================
- Hits 4595 4586 -9
- Misses 966 977 +11
+ Partials 220 218 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -1,6 +1,6 @@ | |||
--- | |||
title: Beyla quick start tutorial | |||
menuTitle: Quick start tutorial | |||
title: Getting started with Beyla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed "quick start" to "getting started" to not generate confusion wit the "quickstart" guides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We update the wording for the k8s tutorial later to match the blogpost if you'd like, so it's up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added aliases for moved tutorials and ran prettier. I will do another change to setup and tutorials as part of a rework of the setup information architecture - this is a good change in the meantime 👍
Rebased and resolved merge conflict. |
This PR adds a tutorial-like version of the WIP blog post
(does not yet include Nikola's changes to the original document).
It also reorganizes the old tutorial and groups it into a tutorials section.
Doing this now would allow us linking the new tutorial as part of the release notes, even before the blog post is published.