Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to group tutorials into a folder #545

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jan 12, 2024

This PR adds a tutorial-like version of the WIP blog post
(does not yet include Nikola's changes to the original document).

It also reorganizes the old tutorial and groups it into a tutorials section.

Doing this now would allow us linking the new tutorial as part of the release notes, even before the blog post is published.

@mariomac mariomac requested a review from grafsean January 12, 2024 11:37
@mariomac mariomac requested a review from grcevski as a code owner January 12, 2024 11:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b832e3) 79.48% compared to head (a636cc6) 79.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   79.48%   79.32%   -0.16%     
==========================================
  Files          69       69              
  Lines        5781     5781              
==========================================
- Hits         4595     4586       -9     
- Misses        966      977      +11     
+ Partials      220      218       -2     
Flag Coverage Δ
integration-test 67.97% <ø> (-0.11%) ⬇️
unittests 45.20% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,6 +1,6 @@
---
title: Beyla quick start tutorial
menuTitle: Quick start tutorial
title: Getting started with Beyla
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed "quick start" to "getting started" to not generate confusion wit the "quickstart" guides.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We update the wording for the k8s tutorial later to match the blogpost if you'd like, so it's up to you.

Copy link
Contributor

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added aliases for moved tutorials and ran prettier. I will do another change to setup and tutorials as part of a rework of the setup information architecture - this is a good change in the meantime 👍

@grafsean
Copy link
Contributor

Rebased and resolved merge conflict.

@grafsean grafsean merged commit 99088fd into grafana:main Jan 15, 2024
5 checks passed
@mariomac mariomac deleted the tutorial branch February 9, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants