Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: clean code for else if #520

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Refactor: clean code for else if #520

merged 1 commit into from
Dec 22, 2023

Conversation

lwangrabbit
Copy link
Contributor

Get rid of else if in early return statement, it may seems more cleaner.

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lwangrabbit lwangrabbit reopened this Dec 22, 2023
@lwangrabbit lwangrabbit marked this pull request as ready for review December 22, 2023 10:14
mariomac
mariomac approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@mariomac mariomac merged commit a28f3b9 into grafana:main Dec 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomac mariomac mariomac approved these changes

@grcevski grcevski Awaiting requested review from grcevski grcevski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwangrabbit @CLAassistant @mariomac