Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s discovery #511

Merged
merged 17 commits into from
Dec 20, 2023
Merged

K8s discovery #511

merged 17 commits into from
Dec 20, 2023

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Dec 19, 2023

Missing:

  • Documentation
  • Integration tests
  • K8s-based decoration of namespaces and service name

@mariomac mariomac requested a review from grcevski as a code owner December 19, 2023 14:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (d9269ab) 78.30% compared to head (625979e) 44.46%.

Files Patch % Lines
pkg/internal/discover/watcher_kube.go 75.00% 45 Missing and 4 partials ⚠️
pkg/internal/discover/finder.go 0.00% 11 Missing ⚠️
pkg/internal/kube/informer.go 71.42% 8 Missing and 2 partials ⚠️
pkg/internal/export/prom/prom.go 0.00% 9 Missing ⚠️
pkg/internal/discover/watcher_proc.go 56.25% 7 Missing ⚠️
pkg/internal/transform/kube/db.go 0.00% 7 Missing ⚠️
pkg/internal/discover/matcher.go 90.62% 2 Missing and 1 partial ⚠️
pkg/internal/discover/services/criteria.go 88.23% 2 Missing ⚠️
pkg/internal/transform/k8s.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #511       +/-   ##
===========================================
- Coverage   78.30%   44.46%   -33.85%     
===========================================
  Files          68       67        -1     
  Lines        5476     5573       +97     
===========================================
- Hits         4288     2478     -1810     
- Misses        964     2943     +1979     
+ Partials      224      152       -72     
Flag Coverage Δ
integration-test ?
unittests 44.46% <72.89%> (+4.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac changed the title WIP: K8s discovery K8s discovery Dec 20, 2023
@mariomac mariomac merged commit 69bcc58 into grafana:main Dec 20, 2023
5 checks passed
@mariomac mariomac deleted the k8s-discovery branch December 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants