Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and document Beyla requirements #500

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

mariomac
Copy link
Contributor

The official docs did not show any requirements section. Also, the README requirements were outdated. We need version 5.8 because we are using BPF_MAP_TYPE_RINGBUF

@mariomac mariomac requested a review from grcevski as a code owner December 11, 2023 14:11
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da4aaef) 77.23% compared to head (6a7b014) 66.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #500       +/-   ##
===========================================
- Coverage   77.23%   66.00%   -11.24%     
===========================================
  Files          67       64        -3     
  Lines        5311     5195      -116     
===========================================
- Hits         4102     3429      -673     
- Misses        988     1493      +505     
- Partials      221      273       +52     
Flag Coverage Δ
integration-test 66.00% <ø> (+0.17%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 4d29a72 into grafana:main Dec 11, 2023
5 checks passed
@mariomac mariomac deleted the update-reqs branch December 11, 2023 14:54
mariomac added a commit to mariomac/beyla that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants