Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for unsupported Go #490

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Add test for unsupported Go #490

merged 1 commit into from
Dec 6, 2023

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Dec 6, 2023

Adds a Go 1.16 basic integration test, which only works because we have:

BEYLA_SKIP_GO_SPECIFIC_TRACERS: "true"

in the config

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (289dec9) 77.14% compared to head (f6f2463) 77.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   77.14%   77.40%   +0.26%     
==========================================
  Files          67       67              
  Lines        5302     5302              
==========================================
+ Hits         4090     4104      +14     
+ Misses        990      979      -11     
+ Partials      222      219       -3     
Flag Coverage Δ
integration-test 66.19% <ø> (+0.30%) ⬆️
unittests 40.42% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@myhro myhro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not that I have powers to actually aprove it but...) it looks good to me!

I left a single question about the autoinstrumenter config filename, but that's definitely not a blocker.

dockerfile: ./test/integration/components/beyla/Dockerfile
command:
- /beyla
- --config=/configs/instrumenter-config-java.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be the Java one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's fine :). The java one doesn't have jaeger in, so I just stole one that existed to avoid making yet another config file.

@grcevski grcevski merged commit 54209a7 into grafana:main Dec 6, 2023
4 checks passed
@grcevski grcevski deleted the test-1.16 branch December 6, 2023 22:34
@grcevski grcevski mentioned this pull request Dec 6, 2023
@mariomac
Copy link
Contributor

mariomac commented Dec 7, 2023

Hi! Thanks for adding this.

I don't get the tests. Shouldn't we just check that Beyla couldn't instrument a given process because it's Go 1.16?

@grcevski
Copy link
Contributor Author

grcevski commented Dec 7, 2023

Yes, this is going to be done through this PR #485. I added the test, but with skipping Go tracers, so that we can use it in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants