Reuse BPF programs in multi-process mode #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
Nov 29, 2023
| // tracers returns Tracer implementer for each discovered eBPF traceable source: GRPC, HTTP... | ||
| func (pt *ProcessTracer) tracers() ([]Tracer, error) { | ||
| loadMux.Lock() |
There was a problem hiding this comment.
Must be locked to force loading of eBPF programs one by one, otherwise we can't properly share the pinned maps, once in a while I get file already exists.
|
Here's some before and after data from running I'm running below 3 HTTPS services, Rust (shared libssl), Node (vendored libssl), Python (shared libssl), with the following configuration: discovery:
services:
- namespace: multi-k
name: rust-service
open_ports: 8490
- namespace: multi-k
name: python-service
open_ports: 8083
- namespace: multi-k
name: nodejs-service
open_ports: 3033 Before (61 probes):After (19 probes): |
mariomac
approved these changes
Nov 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
===========================================
- Coverage 77.17% 40.42% -36.75%
===========================================
Files 65 65
Lines 5183 5170 -13
===========================================
- Hits 4000 2090 -1910
- Misses 962 2945 +1983
+ Partials 221 135 -86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
grcevski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1 we load multiple versions of the same kprobes and uprobes, and use the map filtering by PID to eliminate duplicates. This PR fixes that, allowing for more shared maps and reducing probes loaded to the minimum required. We reuse the kprobes and the probes on libssl.
Closes #395
TODO: