Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go offsets tracker version #449

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

mariomac
Copy link
Contributor

Should fix #443

I haven't been able to reproduce the original issue, as I haven't found any Go distribution with that weird version name. Neither manually installing boringcrypto version nor running with GOEXPERIMENT=boringcrypto.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6452ad7) 78.17% compared to head (2572cc1) 78.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   78.17%   78.42%   +0.25%     
==========================================
  Files          61       61              
  Lines        5039     5028      -11     
==========================================
+ Hits         3939     3943       +4     
+ Misses        888      872      -16     
- Partials      212      213       +1     
Flag Coverage Δ
integration-test 65.90% <ø> (+0.30%) ⬆️
unittests 43.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit e2c0c51 into grafana:main Nov 16, 2023
3 checks passed
@mariomac mariomac deleted the fix-lib-versions branch November 16, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla crashes with malformed library versions
3 participants