Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth encoding backport #447

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mariomac
Copy link
Contributor

Backport of #446
Fixes #442

@mariomac mariomac requested a review from grcevski as a code owner November 16, 2023 14:50
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bcdb9a3) 78.17% compared to head (1023f48) 65.86%.
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/internal/export/otel/grafana.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #447       +/-   ##
===========================================
- Coverage   78.17%   65.86%   -12.31%     
===========================================
  Files          61       58        -3     
  Lines        5039     4933      -106     
===========================================
- Hits         3939     3249      -690     
- Misses        888     1420      +532     
- Partials      212      264       +52     
Flag Coverage Δ
integration-test 65.86% <0.00%> (+0.26%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac changed the base branch from main to release-1.0 November 16, 2023 15:47
@mariomac mariomac merged commit dc1d7fc into grafana:release-1.0 Nov 16, 2023
4 checks passed
@mariomac mariomac deleted the fix-auth-encoding-backport branch November 16, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTEL Enpdoint submission: Beyla does not work with Access Policies key
3 participants