Light refactoring of the TC attachment code #1466
Merged
+129
−220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a light refactoring of the TC attachment code, in order to enable it to be reused between the tracers and netolly. The key changes are:
WatchAndRegisterTC
into multiple atomic functions, that allow them to be used by the netolly flow tracer0xb31N
.Ideally I would have liked to collapse the code gap between the tracers and netolly even more, but that would entail a larger refactoring that requires further discussion, involving sharing the interface informers and registers, so that the interface name cache inside the registerer can be shared. I've thus opted for the pragmatic approach, which translates on sharing the core attachment, qdisc creation and cleanup code, as well as the main watcher loop.