Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation of routes default behavior #1431

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Dec 4, 2024

In a part of the docs it still says that wildcard is the default.

Our own code was also misleading.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Hello @mariomac!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (f517939) to head (afd0f3b).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f517939) and HEAD (afd0f3b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f517939) HEAD (afd0f3b)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1431      +/-   ##
==========================================
- Coverage   81.02%   72.08%   -8.95%     
==========================================
  Files         147      148       +1     
  Lines       15033    15108      +75     
==========================================
- Hits        12181    10890    -1291     
- Misses       2260     3488    +1228     
- Partials      592      730     +138     
Flag Coverage Δ
integration-test 59.14% <ø> (-0.07%) ⬇️
k8s-integration-test 59.24% <ø> (-0.28%) ⬇️
oats-test 33.55% <ø> (-0.19%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit b268b8a into grafana:main Dec 5, 2024
19 of 20 checks passed
@mariomac mariomac deleted the correct-routes branch December 5, 2024 09:23
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
mariomac added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit b268b8a)

Co-authored-by: Mario Macias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants