-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment variable name for configuring otel traces features #1387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
Hello @marctc!
Please, if the current pull request addresses a bug fix, label it with the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
- Coverage 81.09% 81.03% -0.07%
==========================================
Files 147 147
Lines 14745 14745
==========================================
- Hits 11957 11948 -9
- Misses 2205 2213 +8
- Partials 583 584 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Thanks for your contribution @bjor-joh! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-1387-to-release-1.6 origin/release-1.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 66b197574aa1f4fbce0825ba23f488e1c08c219b When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-1387-to-release-1.6
# Create the PR body template
PR_BODY=$(gh pr view 1387 --json body --template 'Backport 66b197574aa1f4fbce0825ba23f488e1c08c219b from #1387{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release-1.6] Fix environment variable name for configuring otel traces features' --body-file - --label 'backport-1.6' --label 'backport-release-1.7' --label 'backport-1.7' --label 'backport-1.8' --label 'backport-release-1.8' --label 'missing-labels' --label 'backport' --base release-1.6 --milestone release-1.6 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-1387-to-release-1.6
# Create a pull request where the `base` branch is `release-1.6` and the `compare`/`head` branch is `backport-1387-to-release-1.6`.
# Remove the local backport branch
git switch main
git branch -D backport-1387-to-release-1.6 |
I believe this should be the correct env