Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1305 to 1.8 #1366

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

grcevski
Copy link
Contributor

Backports the fixes from #1305 to 1.8

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (61514e0) to head (b150a44).
Report is 2 commits behind head on release-1.8.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #1366      +/-   ##
===============================================
- Coverage        81.10%   81.02%   -0.09%     
===============================================
  Files              140      140              
  Lines            14070    14068       -2     
===============================================
- Hits             11411    11398      -13     
- Misses            2138     2147       +9     
- Partials           521      523       +2     
Flag Coverage Δ
integration-test 57.00% <ø> (-0.05%) ⬇️
k8s-integration-test 58.08% <ø> (-0.02%) ⬇️
oats-test 36.27% <ø> (+<0.01%) ⬆️
unittests 52.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac
Copy link
Contributor

LGTM! To publish the docker image we'd also need to backport this PR: #1372

@grcevski grcevski merged commit 9791155 into grafana:release-1.8 Nov 18, 2024
9 of 10 checks passed
@grcevski grcevski deleted the 1.8-backport-1305 branch November 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants