Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formatting to Variable Name #1316

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add Formatting to Variable Name #1316

merged 1 commit into from
Nov 5, 2024

Conversation

SeamusGrafana
Copy link
Contributor

Add Markdown Code Formatting to Variable Name to match other uses in the Doc.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (e335dd7) to head (c5bc96f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   81.06%   81.09%   +0.03%     
==========================================
  Files         143      143              
  Lines       14502    14502              
==========================================
+ Hits        11756    11761       +5     
+ Misses       2172     2166       -6     
- Partials      574      575       +1     
Flag Coverage Δ
integration-test 59.18% <ø> (+0.07%) ⬆️
k8s-integration-test 59.83% <ø> (+0.02%) ⬆️
oats-test 34.54% <ø> (ø)
unittests 51.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello @marctc!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Hello @marctc!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@marctc marctc merged commit 1e2571d into main Nov 5, 2024
24 checks passed
@marctc marctc deleted the SeamusGrafana-patch-1 branch November 5, 2024 10:16
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
(cherry picked from commit 1e2571d)
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
(cherry picked from commit 1e2571d)
marctc pushed a commit that referenced this pull request Nov 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit 1e2571d)

Co-authored-by: SeamusGrafana <102023327+SeamusGrafana@users.noreply.github.com>
marctc pushed a commit that referenced this pull request Nov 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit 1e2571d)

Co-authored-by: SeamusGrafana <102023327+SeamusGrafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants