Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one error with kafka parsing #1253

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

grcevski
Copy link
Contributor

Backport of #1252

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (6eccfa3) to head (d7a6c3d).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8    #1253   +/-   ##
============================================
  Coverage        82.10%   82.10%           
============================================
  Files              140      140           
  Lines            11604    11604           
============================================
+ Hits              9527     9528    +1     
  Misses            1554     1554           
+ Partials           523      522    -1     
Flag Coverage Δ
integration-test 57.92% <0.00%> (-0.09%) ⬇️
k8s-integration-test 59.31% <0.00%> (+0.01%) ⬆️
oats-test 37.07% <100.00%> (ø)
unittests 52.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit d79774e into grafana:release-1.8 Oct 11, 2024
6 checks passed
@grcevski grcevski deleted the fix_kafka_parse_crash-1.8 branch October 11, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants