Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace sampler 1.8 #1241

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Oct 9, 2024

Backport of #1240

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (3339917) to head (14f5fc7).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #1241      +/-   ##
===============================================
+ Coverage        82.06%   82.10%   +0.03%     
===============================================
  Files              140      140              
  Lines            11590    11604      +14     
===============================================
+ Hits              9511     9527      +16     
  Misses            1555     1555              
+ Partials           524      522       -2     
Flag Coverage Δ
integration-test 57.92% <76.92%> (+0.01%) ⬆️
k8s-integration-test 59.21% <69.23%> (+0.06%) ⬆️
oats-test 37.09% <69.23%> (+0.11%) ⬆️
unittests 52.31% <84.61%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski merged commit 6eccfa3 into grafana:release-1.8 Oct 9, 2024
6 checks passed
@grcevski grcevski deleted the fix_trace_sampler_1.8 branch October 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants