Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always decorate k8s_owner_name #1226

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Always decorate k8s_owner_name #1226

merged 3 commits into from
Oct 7, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Oct 4, 2024

The non-standard k8s_owner_name attribute was used in case a given metric had an onwner of an unknown kind.

Following what already do for network metrics, k8s_owner_name will hold the name of the owner even if it is known and already reported in either the k8s_deployment_name, k8s_statefulset_name, k8s_daemonset_name or k8s_replicaset_name.

This would simplify querying and should not have impact in metrics cardinality.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (86c0519) to head (32900fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   81.75%   81.68%   -0.07%     
==========================================
  Files         137      137              
  Lines       11483    11484       +1     
==========================================
- Hits         9388     9381       -7     
- Misses       1558     1563       +5     
- Partials      537      540       +3     
Flag Coverage Δ
integration-test 60.37% <0.00%> (-0.39%) ⬇️
k8s-integration-test 58.18% <100.00%> (-0.11%) ⬇️
oats-test 36.07% <0.00%> (-0.01%) ⬇️
unittests 53.03% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 53e55b2 into grafana:main Oct 7, 2024
12 checks passed
@mariomac mariomac deleted the owner-name branch October 7, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants