-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify HTTP SSL, K probes and NodeJS tracer in a single tracer #1215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 81.89% 81.64% -0.26%
==========================================
Files 137 135 -2
Lines 11489 11435 -54
==========================================
- Hits 9409 9336 -73
- Misses 1544 1561 +17
- Partials 536 538 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Isn't "generic_tracer" too generic name? If we have to change this name to avoid other confunsion/duplicities, I would maybe choose a name that describes what instruments and where are the probes attached (kernel, lib...). |
Do you have any ideas? I can't think of anything better now |
I'd keep it as k_tracer or use generic tracer, maybe protocol_tracer? When you think about it, what the tracer does is detect telemetry signals at the protocol level, by using kprobes and uprobes to parse send/receive buffers. As a contrast to Go tracer, which injects Go uprobes to parts of the Go libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This is a required step in order to reduce privileges required to run Beyla.
This PR unifies the different tracers used for non-Go programs into a generic tracer.
Fixes #1212 and #1213