Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-format-check workflow file #1179

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix clang-format-check workflow file #1179

merged 1 commit into from
Sep 18, 2024

Conversation

rafaelroquetto
Copy link
Contributor

When there were no modified files, grep was returning 1 rather than 0, causing the workflow to fail.

I tested this on a separate draft PR with the following scenarios, and it appears to work:

  • no modified files
  • modified non .c files
  • modified .c files (format compliant)
  • modified .c files (non-compilant)

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (f71ed30) to head (9c59e5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1179      +/-   ##
==========================================
+ Coverage   81.17%   81.24%   +0.06%     
==========================================
  Files         136      136              
  Lines       11447    11447              
==========================================
+ Hits         9292     9300       +8     
+ Misses       1629     1624       -5     
+ Partials      526      523       -3     
Flag Coverage Δ
integration-test 57.03% <ø> (-0.01%) ⬇️
k8s-integration-test 58.90% <ø> (+0.08%) ⬆️
oats-test 35.81% <ø> (ø)
unittests 53.52% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelroquetto rafaelroquetto merged commit 5c8c8c2 into main Sep 18, 2024
8 checks passed
@rafaelroquetto rafaelroquetto deleted the clang-fix branch September 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants