Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid that a Pod update removes the container metadata #1156

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mariomac
Copy link
Contributor

Fixes: #1152

After a Pod update event, the container metadata was removed but never restored, so the PIDs<->Pod information was lost.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (487a85a) to head (fc0f1f5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   81.96%   81.82%   -0.14%     
==========================================
  Files         141      136       -5     
  Lines       11595    11287     -308     
==========================================
- Hits         9504     9236     -268     
+ Misses       1563     1529      -34     
+ Partials      528      522       -6     
Flag Coverage Δ
integration-test 57.48% <ø> (+0.27%) ⬆️
k8s-integration-test 59.38% <ø> (+0.30%) ⬆️
oats-test 36.03% <ø> (-0.83%) ⬇️
unittests 53.88% <ø> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac added the bug label Sep 10, 2024
@mariomac mariomac merged commit 2f9cf72 into grafana:main Sep 10, 2024
8 checks passed
@mariomac mariomac deleted the fix-pod-rm branch September 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla looses K8s metadata after ~20m
4 participants