Increase buffer size to 192 to capture longer URLs #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marevers
requested review from
grcevski,
mariomac,
marctc and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
+ Coverage 78.39% 81.04% +2.64%
==========================================
Files 136 136
Lines 11416 11416
==========================================
+ Hits 8950 9252 +302
+ Misses 1919 1637 -282
+ Partials 547 527 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marevers
force-pushed
the
increase-buf-size
branch
from
2b40c71 to
e4557ca
Compare
|
Rebased and rebuilt BPF. |
|
I'm so sorry, but it seems we conflicted on eBPF one more time. Will you please rebase one more time, we'll hold off eBPF changes until you do so. Sorry again for the inconvenience. |
marevers
force-pushed
the
increase-buf-size
branch
from
c72620d to
95f71c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1097
This PR increases FULL_BUF_SIZE from 160 to 192, which allows for capturing longer URLs. Slightly longer URLs can get cut off with 160, with 192 they get captured fully.