Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate instance ids and restore target_instance in Prometheus #1129

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Sep 4, 2024

Should fix #1124

This PR also changes the way instance IDs are composed, to avoid letting them grow too much. Now they are just Base32 hashes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.05%. Comparing base (ecc9dc1) to head (42165b4).

Files with missing lines Patch % Lines
pkg/internal/request/span_getters.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   73.06%   82.05%   +8.99%     
==========================================
  Files         139      141       +2     
  Lines       11553    11586      +33     
==========================================
+ Hits         8441     9507    +1066     
+ Misses       2454     1556     -898     
+ Partials      658      523     -135     
Flag Coverage Δ
integration-test 57.36% <89.28%> (+0.01%) ⬆️
k8s-integration-test 59.31% <92.85%> (+0.21%) ⬆️
oats-test 36.92% <57.14%> (+0.05%) ⬆️
unittests 52.38% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 85dfbd4 into grafana:main Sep 4, 2024
6 checks passed
@mariomac mariomac deleted the fix-instance branch September 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processes: mess with target_info's instance attribute (OTEL export)
3 participants