Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'watch services' permission to unprivileged example #1126

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

marevers
Copy link
Contributor

@marevers marevers commented Sep 3, 2024

The unprivileged Kubernetes example is missing the 'watch services' permission which is causing the following error to appear in the logs of all pods:

E0903 10:21:26.617356 2510180 reflector.go:147] k8s.io/client-go/informers/factory.go:159: Failed to watch *v1.Service: unknown (get services)

This PR adds the missing permission to the Cluster Role.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@mariomac mariomac merged commit fe444df into grafana:main Sep 3, 2024
6 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (9a20dda) to head (75964da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   82.03%   82.01%   -0.03%     
==========================================
  Files         140      140              
  Lines       11574    11574              
==========================================
- Hits         9495     9492       -3     
  Misses       1557     1557              
- Partials      522      525       +3     
Flag Coverage Δ
integration-test 57.20% <ø> (-0.12%) ⬇️
k8s-integration-test 59.16% <ø> (-0.12%) ⬇️
oats-test 36.87% <ø> (-0.02%) ⬇️
unittests 52.31% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marevers marevers deleted the unpriviliged-watch-services branch September 10, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants