Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename beyla_build_info for internal registry #1119

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Aug 29, 2024

When Beyla is configured to have same port and path for prometheus exporter and internal metrics
means that the same Prometheus registry. This causes a panic because it tries to register beyla_build_info.

I tried different approaches to avoid register duplicated metrics but all the implementations are quite hacky,
as there's not a proper way to see if a metric is already register.

The easiest approach is to rename beyla_build_info to beyla_internal_build_info. So far it would only break
the internal debug dashboard.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (e98ffbf) to head (05ced0f).

Files with missing lines Patch % Lines
pkg/internal/imetrics/iprom.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   82.02%   82.00%   -0.02%     
==========================================
  Files         140      140              
  Lines       11521    11520       -1     
==========================================
- Hits         9450     9447       -3     
- Misses       1550     1551       +1     
- Partials      521      522       +1     
Flag Coverage Δ
integration-test 57.71% <50.00%> (+0.16%) ⬆️
k8s-integration-test 59.24% <50.00%> (+0.10%) ⬆️
oats-test 37.05% <0.00%> (-0.02%) ⬇️
unittests 52.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marctc marctc merged commit 4494fae into main Aug 30, 2024
9 checks passed
@marctc marctc deleted the rename_internal_metric branch August 30, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants