Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s net attributes: default src/dst owner type #1114

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

mariomac
Copy link
Contributor

These attributes do not add cardinality and would make Beyla to behave as the Helm chart according to the changes here: https://github.com/grafana/beyla/pull/1112/files#r1733520420

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (e7d67e4) to head (edd5cdf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   82.00%   82.07%   +0.07%     
==========================================
  Files         140      140              
  Lines       11517    11521       +4     
==========================================
+ Hits         9444     9456      +12     
+ Misses       1551     1546       -5     
+ Partials      522      519       -3     
Flag Coverage Δ
integration-test 57.53% <100.00%> (+0.44%) ⬆️
k8s-integration-test 59.23% <100.00%> (-0.01%) ⬇️
oats-test 37.04% <100.00%> (-0.02%) ⬇️
unittests 52.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit e98ffbf into grafana:main Aug 29, 2024
6 checks passed
@mariomac mariomac deleted the owner-types branch August 29, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants