Terminate Beyla if we can't open a configured Prometheus port #1111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyla can fail to register the HTTP Prometheus metrics endpoint because of number of reasons. It can be that the port is already opened or we don't have permission to listen on a specific port.
Currently, when we fail to open the Prometheus port the Beyla process prints an error message, but then successfully runs. Successful run can be misleading, since for the end users there is no indication that the process is unhealthy and the error message is buried in the very first few lines of the logs. The symptom is metrics are not scraped, but Beyla is up and running.
This PR causes Beyla to terminate as soon as we fail to register the port. We can't add early validation for this error scenario, because we can't predict all of the possible reasons we may not be able to open the Prometheus port.