Split iovec reading for tcp_recvmsg #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
requested review from
mariomac,
marctc and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
==========================================
- Coverage 81.96% 78.93% -3.03%
==========================================
Files 140 140
Lines 11514 11514
==========================================
- Hits 9437 9089 -348
- Misses 1553 1898 +345
- Partials 524 527 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
approved these changes
Aug 27, 2024
mariomac
approved these changes
Aug 27, 2024
|
Please don't merge this just yet, I'm investigating a few failing tests on 5.x that may or may not be related. |
rafaelroquetto
approved these changes
Aug 27, 2024
|
Retested on 5.x with latest changes, all tests pass. Merging so that I can rebase the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression fix for a refactor we did in the last 2 months to read multiple segments of the iov pointer inside msghdr. In case of a large incoming request, the kernel buffer used for iov might be replenished and we'll loose the pointer to the original buffer, if we read the iov address at probe return.
After the nice refactor of the code by @rafaelroquetto, it was easy to separate the acquisition of the iov pointer from the reading of the data. I had to duplicate the data structure for the purpose of keeping the iov pointers, since we can't use pointers in eBPF maps value structs.