Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage exclusion pattern #1106

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix coverage exclusion pattern #1106

merged 2 commits into from
Aug 26, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (a1bf318) to head (38a5e6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   73.62%   81.93%   +8.30%     
==========================================
  Files         172      140      -32     
  Lines       13093    11450    -1643     
==========================================
- Hits         9640     9381     -259     
+ Misses       2904     1547    -1357     
+ Partials      549      522      -27     
Flag Coverage Δ
integration-test 56.78% <ø> (+5.26%) ⬆️
k8s-integration-test 59.11% <ø> (+5.83%) ⬆️
oats-test 37.03% <ø> (+3.51%) ⬆️
unittests 52.11% <ø> (+6.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!!!! LGTM!

@mariomac mariomac merged commit 74ba237 into grafana:main Aug 26, 2024
6 checks passed
@mariomac mariomac deleted the fix-cov branch August 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants