Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slog errors #1104

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix slog errors #1104

merged 1 commit into from
Aug 26, 2024

Conversation

rafaelroquetto
Copy link
Contributor

A few tests contained wrong slog statements that led to errors such as

 slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)  

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (f632c99) to head (8c4d065).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   73.50%   73.16%   -0.34%     
==========================================
  Files         172      172              
  Lines       13091    13091              
==========================================
- Hits         9622     9578      -44     
- Misses       2920     2968      +48     
+ Partials      549      545       -4     
Flag Coverage Δ
integration-test 50.79% <ø> (-0.24%) ⬇️
k8s-integration-test 52.92% <ø> (+0.05%) ⬆️
oats-test 33.52% <ø> (-0.21%) ⬇️
unittests 45.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome, thanks for fixing it.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! To put in context, the experimental API of the slog library required that the second argument of the Error method was an actual error. We updated the library when it was made part of Go, but we forgot to update some invocations.

Thanks for fixing!

@mariomac mariomac merged commit a1bf318 into main Aug 26, 2024
6 checks passed
@mariomac mariomac deleted the slog_errors branch August 26, 2024 14:58
@mariomac
Copy link
Contributor

Merging to unblock other failing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants