Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate timeout greater than 0s for InformersSyncTimeout #1103

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Aug 23, 2024

In early stages of Beyla Alloy integration this flag was set to 0 and Beyla was crashing.
This PR adds a validation (tho i wasn't able to replicate the error this time, so just in case).

Fixes #739

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.56%. Comparing base (f632c99) to head (62a08b5).

Files Patch % Lines
pkg/beyla/config.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   73.50%   73.56%   +0.06%     
==========================================
  Files         172      172              
  Lines       13091    13093       +2     
==========================================
+ Hits         9622     9632      +10     
+ Misses       2920     2911       -9     
- Partials      549      550       +1     
Flag Coverage Δ
integration-test 51.00% <0.00%> (-0.04%) ⬇️
k8s-integration-test 52.99% <0.00%> (+0.12%) ⬆️
oats-test 33.72% <0.00%> (-0.01%) ⬇️
unittests 45.66% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 51c1f33 into main Aug 26, 2024
6 checks passed
@marctc marctc deleted the add_timeout_validation branch August 26, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla crashes when some Kubernetes properties are missing
3 participants