Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory optimizations for various parts of the code #1096

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

grcevski
Copy link
Contributor

Rebuilds what we had in #1028, without the parts that might be problematic.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.64%. Comparing base (d433fd4) to head (6543f2c).

Files Patch % Lines
pkg/internal/infraolly/process/snapshot.go 0.00% 5 Missing and 1 partial ⚠️
pkg/export/alloy/traces.go 0.00% 0 Missing and 1 partial ⚠️
pkg/export/otel/metrics.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
+ Coverage   70.64%   73.64%   +3.00%     
==========================================
  Files         172      172              
  Lines       13073    13091      +18     
==========================================
+ Hits         9235     9641     +406     
+ Misses       3273     2906     -367     
+ Partials      565      544      -21     
Flag Coverage Δ
integration-test 51.03% <45.45%> (?)
k8s-integration-test 52.97% <43.18%> (+0.12%) ⬆️
oats-test 33.78% <34.09%> (+0.28%) ⬆️
unittests 45.66% <79.54%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski grcevski merged commit 3fd9525 into grafana:main Aug 20, 2024
6 checks passed
@grcevski grcevski deleted the mem_opts branch August 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants