Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt fix missing http calls #1092

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Conversation

grcevski
Copy link
Contributor

Based on some recent logs of Java running on kernels 5.10 and 5.15 we see missing prints for the kretprobes of tcp_recvmsg. Some succeed on rare occasions, but most don't run.

This PR:

  • Fixes the socket filter backup path
  • Attempts to handle the case where buffers may be read incompletely in tcp_recvmsg.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.84%. Comparing base (ef14616) to head (5d268a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
+ Coverage   70.58%   73.84%   +3.26%     
==========================================
  Files         172      172              
  Lines       13066    13066              
==========================================
+ Hits         9222     9649     +427     
+ Misses       3280     2869     -411     
+ Partials      564      548      -16     
Flag Coverage Δ
integration-test 51.03% <ø> (?)
k8s-integration-test 53.28% <ø> (+0.39%) ⬆️
oats-test 33.66% <ø> (+0.20%) ⬆️
unittests 45.66% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gnarly!

@grcevski grcevski merged commit c8f170d into grafana:main Aug 15, 2024
6 checks passed
@grcevski grcevski deleted the fix_missing_http_calls branch August 15, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants