Helm Chart 1.3.0 with Beyla 1.7.0 #1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also reverts this PR #961
The idea behind having a default open Prometheus port was to allow a real single-command installation of Beyla without any kind of configuration. Just having a Beyla working with defaults.
You can have without problem this:
or even:
As the Beyla prometheus manager is smart enough to detect when both exporters go to the same port and path, and redirect there all the metrics.
I'm not sure if we really want to enable internal metrics by default to our users. It seems that, in the original code, what was wrong was the comment saying this was internal metrics, but not the fact of being exporting prometheus metrics by default.