Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Chart 1.3.0 with Beyla 1.7.0 #1078

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Helm Chart 1.3.0 with Beyla 1.7.0 #1078

merged 2 commits into from
Aug 5, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Aug 2, 2024

This PR also reverts this PR #961

The idea behind having a default open Prometheus port was to allow a real single-command installation of Beyla without any kind of configuration. Just having a Beyla working with defaults.

You can have without problem this:

    prometheus_export:
      port: 9090
      path: /metrics
    internal_metrics:
      prometheus:
        port: 9090
        path: /metrics

or even:

    prometheus_export:
      port: 9090
      path: /metrics
    internal_metrics:
      prometheus:
        port: 9090
        path: /internal/metrics

As the Beyla prometheus manager is smart enough to detect when both exporters go to the same port and path, and redirect there all the metrics.

I'm not sure if we really want to enable internal metrics by default to our users. It seems that, in the original code, what was wrong was the comment saying this was internal metrics, but not the fact of being exporting prometheus metrics by default.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (f88413a) to head (b5c51d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   81.90%   81.99%   +0.08%     
==========================================
  Files         139      139              
  Lines       11329    11329              
==========================================
+ Hits         9279     9289      +10     
+ Misses       1534     1528       -6     
+ Partials      516      512       -4     
Flag Coverage Δ
integration-test 57.19% <ø> (+0.27%) ⬆️
k8s-integration-test 59.42% <ø> (+0.09%) ⬆️
oats-test 36.90% <ø> (-0.02%) ⬇️
unittests 51.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 5d75be2 into grafana:main Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants